Fix considered data in ExtEntityMapping.getAssets()
#385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staudtMarius
added
bug
danielfeismann
requested changes
Nov 17, 2025
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
LGTM, but some tests would be great.
And please add within the issue some details what was the problem here
danielfeismann
approved these changes
Nov 17, 2025
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Thanks for adding some tests!
danielfeismann
deleted the
ms/#384-Fix-considered-data-in-ExtEntityMapping-getAssets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #384