This repository was archived by the owner on Jun 8, 2025. It is now read-only.
feat: add mongo_uri config option#338
Closed
rickbassham wants to merge 1 commit intoiegomez:masterfrom
Closed
Conversation
iegomez
reviewed
Sep 22, 2024
Owner
iegomez
left a comment
iegomez
left a comment
There was a problem hiding this comment.
Could you add a test for the change?
iegomez
reviewed
Sep 22, 2024
| var addr string | ||
|
|
||
| if mongoUri, ok := authOpts["mongo_uri"]; ok { | ||
| addr = mongoUri |
Owner
There was a problem hiding this comment.
Is there some standard validation to run against the uri?
Author
There was a problem hiding this comment.
The existing mongo.Connect method will validate it and return an appropriate error if the URI is bad.
Owner
|
@rickbassham let me know if you plan on adding that test I mentioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
mongo_uriconfig option to specify the entire mongo uri. This allows for more complex connection strings.