Skip to content

fix: need to check final approval#80

Merged
holloway merged 1 commit into
mainfrom
fix/check-for-action-holder
May 21, 2026
Merged

fix: need to check final approval#80
holloway merged 1 commit into
mainfrom
fix/check-for-action-holder

Conversation

@rudimatz
Copy link
Copy Markdown
Contributor

@rudimatz rudimatz commented May 21, 2026

need to check for finalApprovals here, not actionHolderrs

@rudimatz rudimatz requested a review from holloway May 21, 2026 15:41
@rudimatz
Copy link
Copy Markdown
Contributor Author

rudimatz commented May 21, 2026

will fix issue reported by @alicerusso

Q: How come no names listed under 'Approval Status' on
https://queue.rfc-editor.org/final-review/rfc9955/ ?
Expected the names shown here:
https://purple.rfc-editor.org/docs/draft-ietf-pquip-hybrid-signature-spectrums/approvals
In contrast:  (as expected)
https://queue.rfc-editor.org/final-review/rfc9974/
shows the names listed here:
https://purple.rfc-editor.org/docs/draft-ietf-bier-oam-requirements/approvals

@rudimatz
Copy link
Copy Markdown
Contributor Author

rudimatz commented May 21, 2026 •
edited
Loading

to validate after deploy:
image

should display Final Approvals

@holloway holloway merged commit 59b27a9 into main May 21, 2026
1 check passed
@holloway holloway deleted the fix/check-for-action-holder branch May 21, 2026 20:49
@rudimatz
Copy link
Copy Markdown
Contributor Author

rudimatz commented May 21, 2026

addresses #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holloway holloway holloway approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rudimatz @holloway