feat(i18n): implement English fallback for missing translation keys #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
- Add deepMerge function to intelligently merge fallback messages - English translations automatically fill missing keys in non-English locales - Zero performance impact for English users (fallback skipped) - Minimal performance impact for other locales (single additional import) - Comprehensive test suite with 9 test cases covering edge cases - Fully backward compatible - existing translations remain unchanged - Resolves MISSING_MESSAGE errors that previously crashed applications Technical Details: - Only loads English fallback for non-English locales - Uses shallow copy + selective deep merge for memory efficiency - Preserves existing translations, only fills undefined keys - Handles nested objects, arrays, null/undefined values correctly
lyzno1
force-pushed
the
feat/i18n-fallback-english
branch
from
000210d to
177593f
Compare
zhangxuhe1
previously approved these changes
Aug 4, 2025
Test job was being skipped because it depends on install job, but install job only ran for source/config changes. Now install job also runs for test file changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why
What: Implement English fallback mechanism for missing translation keys in next-intl configuration
Why: Prevents MISSING_MESSAGE errors that crash the application when translation keys are missing from non-English locale files
Technical Implementation
Pre-PR Checklist
All checks completed:
Type
Test Results
PASS i18n/fallback.test.ts - 9/9 tests passed
Before & After
Before: MISSING_MESSAGE errors crash application
After: English fallback displays, application continues normally
This enhancement makes the application more robust and developer-friendly while maintaining full backward compatibility.