feat(admin): integrate image upload into content editor #288
Conversation
- Add 'Upload' button to image component src field - Open ImageUploadDialog when clicked - Auto-fill uploaded image URL to src field - Keep existing URL input functionality intact - Fetch userId from Supabase auth on component mount Closes ifLabX#250
|
@pixelsama is attempting to deploy a commit to the zhang's projects Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:M
Summary of ChangesHello @pixelsama, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the content editor by introducing a streamlined process for adding images. It provides a convenient user interface that allows content creators to upload local images directly from the editor, eliminating the need for manual URL management and completing the image upload feature implementation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
dosubot
bot
added
area:ui
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully integrates an image upload dialog into the content editor's context menu, providing a much-needed UI for uploading images directly. The implementation is solid. My feedback includes a few suggestions to improve robustness and code clarity, such as handling asynchronous state updates more safely, improving the user experience by disabling the upload button when not ready, and removing a redundant state update call.
- Add isMounted flag to prevent memory leaks in async useEffect - Disable Upload button when userId is not yet loaded - Remove redundant dialog close call in onUploadSuccess handler
2 participants
Important
Fixes #<issue number>What & Why
What: Add "Upload Image" button to image component src field in content editor
Why: Provides convenient UI for uploading local images directly from the editor, completing the image upload feature implementation
Closes #250
Pre-PR Checklist
Run these:
pnpm type-checkpnpm format:checkpnpm lintpnpm buildpnpm i18n:check(if applicable)Type
Screenshots (if UI changes)
N/A - Will be visible when testing the content editor with image components