Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/chatwithNo 'Access-Control-Allow-Origin' header is presentbecause the preflightOPTIONSresponse did not consistently include CORS headers, so the server must always respond to preflight and expose the expected headers.Description
cors()middleware and added a whitelistALLOWED_ORIGINSset includinghttps://iflytek.github.ioand local Vite origins.applyCorsto setAccess-Control-Allow-Origin,Vary,Access-Control-Allow-Methods, andAccess-Control-Allow-Headerswhen the requestOriginmatches the whitelist.204forOPTIONSrequests while leaving the existing/api/chatproxy logic intact.Testing
node -c server.js, which succeeded.curl -i -X OPTIONS 'http://127.0.0.1:3001/api/chat' -H 'Origin: https://iflytek.github.io' -H 'Access-Control-Request-Method: POST' -H 'Access-Control-Request-Headers: content-type', which returned204 No Contentwith the expected CORS headers.POSTwithcurlwhich reached the server and included CORS headers but the upstream proxyfetchfailed in this environment (so POST reachability to the external API remains an external/network issue).Codex Task