fix(storage): support path-style by s3 force-path-style config#251
Merged
Conversation
vsxd
approved these changes
Apr 10, 2026
Rsweater
pushed a commit
to Rsweater/skillhub
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
修复 S3Presigner 未读取
forcePathStyle配置导致预签名 URL 始终使用 host-style 的问题。变更内容
后端实现
S3StorageService中抽取buildPresigner(),统一构建S3PresignerS3Configuration.pathStyleAccessEnabled(properties.isForcePathStyle())前端实现
测试覆盖
S3StorageServiceTestforcePathStyle=true时断言生成 path-style URL(/bucket/key)forcePathStyle=false时断言生成 host-style URL(bucket.host/key)质量门禁
make typecheck-web通过(0 errors)make lint-web通过(0 errors, 0 warnings)make test-frontend通过make test-backend-app通过(如有后端变更)web/e2e)关键路径通过(如有 UI 交互变更)make generate-api已执行且schema.d.ts已提交(如有 Controller 变更)安全考虑
本次变更不涉及安全敏感内容。
相关 Issue
Closes #248
测试说明
本地验证步骤
skillhub.storage.provider=s3并配置 S3/MinIO endpoint 与凭证skillhub.storage.s3.force-path-style=true/false回归测试范围
截图/录屏(如有 UI 变更)
无