Skip to content

fix register validation, review visibility, and search e2e coverage#269

Merged
tenten-shih merged 8 commits intomainfrom
pr/exclude-playwright-report
Apr 9, 2026
Merged

fix register validation, review visibility, and search e2e coverage#269
tenten-shih merged 8 commits intomainfrom
pr/exclude-playwright-report

Conversation

@tenten-shih
Copy link
Copy Markdown
Collaborator

Summary

  • fix register form API error mapping and add missing i18n messages
  • sync review and promotion approval state before returning updated tasks
  • refine search empty-state behavior and card keyboard interaction
  • add e2e coverage for register/login validation and search result interactions

Verification

  • bash scripts/run-playwright-with-report.sh e2e --grep "TC_REG_003: shows error when registering with existing username"
  • npx playwright test e2e/search-page-full.spec.ts e2e/search-card-interaction.spec.ts --grep "TC_SEARCH_INPUT_003: empty search shows keyword guidance instead of a default list|TC_SEARCH_INTERACT_007: clicking a skill card navigates to the skill detail page"
  • ./mvnw -pl skillhub-app -am -Dtest=ReviewServiceTest,PromotionServiceTest,SkillApprovalVisibilityFlowIntegrationTest -Dsurefire.failIfNoSpecifiedTests=false test

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 9, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tenten-shih
❌ huishi3


huishi3 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tenten-shih tenten-shih merged commit 77e271f into main Apr 9, 2026
3 of 4 checks passed
@tenten-shih tenten-shih deleted the pr/exclude-playwright-report branch April 9, 2026 09:29
Rsweater pushed a commit to Rsweater/skillhub that referenced this pull request Apr 16, 2026
fix register validation, review visibility, and search e2e coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants