Skip to content

fix(search): align portal visibility for private skills#323

Merged
XiaoSeS merged 6 commits intomainfrom
fix/search-visibility-super-admin
Apr 17, 2026
Merged

fix(search): align portal visibility for private skills#323
XiaoSeS merged 6 commits intomainfrom
fix/search-visibility-super-admin

Conversation

@XiaoSeS
Copy link
Copy Markdown
Collaborator

@XiaoSeS XiaoSeS commented Apr 17, 2026

Summary

  • remove super admin expanded visibility from the public search portal
  • exclude skill-owner-only private skills from normal search results
  • keep private skills searchable for namespace admins and namespace owners

Test plan

  • mvn compile -pl skillhub-search,skillhub-app -am --no-transfer-progress
  • verify PUBLIC skills remain searchable for all users
  • verify NAMESPACE_ONLY skills are searchable only to namespace members
  • verify PRIVATE skills are searchable only to namespace admins/owners
  • verify skill-owner-only PRIVATE skills appear only in '我创建的' rather than portal search

XiaoSeS added 2 commits April 17, 2026 13:58
- Add GitHub Models integration for automated release notes
- Support bilingual (EN) release notes with highlights extraction
- Fallback to conventional commit grouping when LLM unavailable
- Trigger on tag push or manual workflow dispatch
- Zero configuration: uses GitHub Models (gpt-4o-mini) by default
- Pin checkout and setup-deno to commit hashes matching project convention
- Add .playwright-mcp/ and .mcp.json to gitignore
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

- remove super admin expanded visibility from portal search
- exclude all private skills from portal search results
- keep namespace-only skills visible only to namespace members
- reserve private skill access for my-skills and future admin surfaces
@XiaoSeS XiaoSeS force-pushed the fix/search-visibility-super-admin branch from 96698c5 to 279b4a9 Compare April 17, 2026 08:21
XiaoSeS added 3 commits April 17, 2026 17:01
- rename test from platformWideAccessShouldBypass... to platformWideAccessShouldNotBypass...
- verify that platformWideAccess flag does not grant extra visibility in portal search
- verify PRIVATE skills are excluded from search SQL
- aligns test with new requirement: portal search uses standard visibility rules
- rename test from search_shouldGrantPlatformWideAccessToSuperAdmin to search_shouldNotGrantPlatformWideAccessToSuperAdminInPortal
- verify super admin does not get platformWideAccess in portal search
- aligns with requirement: portal uses standard visibility, admin features reserved for dedicated interface
@XiaoSeS XiaoSeS merged commit 080be28 into main Apr 17, 2026
2 of 4 checks passed
@XiaoSeS XiaoSeS deleted the fix/search-visibility-super-admin branch April 17, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants