Remove jackknife variance estimation from TROP#124
Merged
Conversation
Jackknife was never specified in the source paper (Athey et al. 2025); bootstrap is the only variance method described. This removes the variance_method parameter, both jackknife implementation methods, and all related references from code, tests, and documentation. Breaking change: TROP(variance_method=...) now raises TypeError; TROPResults no longer has a variance_method field. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Overall Assessment
Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variance_methodparameter fromTROP.__init__()andTROPResultsdataclass_jackknife_variance()and_jackknife_variance_joint()methods (~180 lines)Breaking change:
TROP(variance_method=...)now raisesTypeError;TROPResults.variance_methodno longer exists. Jackknife was never specified in the source paper — bootstrap is the only inference method described in Athey et al. (2025).Methodology references (required if estimator / math changes)
Validation
tests/test_trop.py— 4 jackknife tests deleted, 5 tests updated to removevariance_methodkwarg. 80 tests pass.docs/tutorials/10_trop.ipynbcells 24-25 rewritten for bootstrap-only variance.TROP(variance_method="bootstrap")raisesTypeError(clean removal)trop()convenience function still worksSecurity / privacy
Generated with Claude Code