Fix RTD docs build failure caused by Rust/maturin compilation timeout#151
Merged
Fix RTD docs build failure caused by Rust/maturin compilation timeout#151
Conversation
The PR #146 change to build from source triggers maturin, which compiles the full Rust backend (faer, pyo3, rayon) with LTO — exceeding RTD's build limits. The Rust backend is unnecessary for docs. - Remove Rust toolchain and pip install from .readthedocs.yaml - Install only runtime + docs deps via post_install hook - Add sys.path insert in docs/conf.py so autodoc imports from source Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Overall assessment: Looks good Executive summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install .(maturin build) from.readthedocs.yaml— the Rust backend is unnecessary for docs and exceeds RTD build limitspost_installhooksys.path.insertindocs/conf.pyso autodoc importsdiff_difffrom the checked-out source (preserving the PR SyntheticDiD docs/examples use zeta_omega/zeta_lambda, but diff-diff==2.3.0 constructor only accepts lambda_reg/zeta #146 fix for version-matched docs)Methodology references (required if estimator / math changes)
Validation
cd docs && python -c "import sys; sys.path.insert(0, '..'); import diff_diff; print(diff_diff.__version__)"prints2.3.1Security / privacy
Generated with Claude Code