Skip to content

docs: mark B2b Geo-Experiment tutorial as done in ROADMAP#291

Merged
igerber merged 1 commit intomainfrom
docs/b2b-roadmap-status
Apr 11, 2026
Merged

docs: mark B2b Geo-Experiment tutorial as done in ROADMAP#291
igerber merged 1 commit intomainfrom
docs/b2b-roadmap-status

Conversation

@igerber
Copy link
Copy Markdown
Owner

@igerber igerber commented Apr 11, 2026

Summary

PR #289 shipped Tutorial 18 (18_geo_experiments.ipynb) but ROADMAP.md still listed B2b as "In progress" with a description mentioning the GeoLift/CausalImpact comparison. That comparison was explicitly dropped from Tutorial 18 in commit 96d2eea and remains scoped under the separate B2c row ("diff-diff vs GeoLift vs CausalImpact comparison page").

  • Flip B2b status to "Done (Tutorial 18)"
  • Drop the "comparison with GeoLift/CausalImpact" mention from B2b's description (B2c still tracks that work independently)

Methodology references (required if estimator / math changes)

  • Method name(s): N/A - no methodology or estimator changes
  • Paper / source link(s): N/A
  • Any intentional deviations from the source (and why): None

Validation

  • Tests added/updated: No test changes (single-line roadmap status update)
  • Backtest / simulation / notebook evidence (if applicable): N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

PR #289 shipped Tutorial 18 (18_geo_experiments.ipynb) but ROADMAP.md
still listed B2b as "In progress" with a description that mentioned
the GeoLift/CausalImpact comparison. That comparison was explicitly
dropped from the tutorial in commit 96d2eea and remains scoped under
the separate B2c row.

- Flip B2b status to "Done (Tutorial 18)"
- Drop the "comparison with GeoLift/CausalImpact" mention (B2c still
  tracks that work independently)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@igerber
Copy link
Copy Markdown
Owner Author

igerber commented Apr 11, 2026

/ai-review

@github-actions
Copy link
Copy Markdown

🔁 AI review rerun (requested by @igerber)

Head SHA: 5460c58e2e6b407155ec4128a0aa3b468fcb8662


Overall Assessment

Looks good (highest unmitigated severity: P3).

Executive Summary

Methodology

No findings. The PR only updates roadmap text in ROADMAP.md:L90-L91. SyntheticDiD methodology remains documented separately in docs/methodology/REGISTRY.md and referenced from docs/tutorials/18_geo_experiments.ipynb:L44-L48; no estimator, weighting, variance/SE, identification assumption, or default behavior changed.

Code Quality

No findings. The change is limited to roadmap copy and status.

Performance

No findings. No executable code path changed.

Maintainability

No findings in the changed file. The revised B2b row is clearer because it separates the shipped tutorial from the still-pending comparison page in ROADMAP.md:L90-L91.

Tech Debt

No findings. Nothing here needs TODO tracking.

Security

No findings. This is a documentation-only change with no secrets or executable-surface impact.

Documentation/Tests

  • Severity: P3. Impact: After ROADMAP.md:L90-L91 makes the B2b tutorial a completed SyntheticDiD walkthrough and leaves the GeoLift/CausalImpact comparison as separate B2c work, docs/business-strategy.md:L237-L240 still says the tutorial’s unique value is a direct GeoLift/CausalImpact comparison. That leaves planning docs inconsistent about scope. Concrete fix: Update docs/business-strategy.md:L237-L240 to describe the geo-experiment tutorial as the SDiD walkthrough, and keep comparison language only on the dedicated comparison-page item.

@igerber igerber added the ready-for-ci Triggers CI test workflows label Apr 11, 2026
@igerber igerber merged commit 81d9960 into main Apr 11, 2026
1 check failed
@igerber igerber deleted the docs/b2b-roadmap-status branch April 11, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-ci Triggers CI test workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant