Skip to content

Release 3.3.2: dCDH by_path × trends extensions, Yatchew mean_independence, HAD Phase 4 R-parity#400

Merged
igerber merged 1 commit intomainfrom
release/3.3.2
Apr 27, 2026
Merged

Release 3.3.2: dCDH by_path × trends extensions, Yatchew mean_independence, HAD Phase 4 R-parity#400
igerber merged 1 commit intomainfrom
release/3.3.2

Conversation

@igerber
Copy link
Copy Markdown
Owner

@igerber igerber commented Apr 26, 2026

Summary

  • Bump version 3.3.1 → 3.3.2 across the 6 version surfaces
  • Rename CHANGELOG `[Unreleased]` → `[3.3.2] - 2026-04-26`; add comparison link

Highlights since 3.3.1

Methodology references

  • N/A for this PR — version-bump only; no source code, methodology, or Rust changes
  • Methodology citations for all underlying work are in `docs/methodology/REGISTRY.md` and the section-level CHANGELOG entries

Validation

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

…dence, HAD Phase 4 R-parity, Rust rand bump

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Overall Assessment

✅ Looks good

Executive Summary

  • The diff is release metadata only: version bumps plus changelog promotion from Unreleased to 3.3.2; I found no in-scope estimator, weighting, variance/SE, identification, or default-behavior code changes.
  • The methodology-heavy changelog content already maps to documented registry notes/deviations for dCDH by_path, HAD trends_lin, and yatchew_hr_test(null="mean_independence"), so there is no new undocumented methodology mismatch in scope (docs/methodology/REGISTRY.md:L641-L675, docs/methodology/REGISTRY.md:L2470-L2503, TODO.md:L104-L106).
  • The main release/version surfaces are internally synchronized to 3.3.2 in CHANGELOG.md:L8, CITATION.cff:L10-L11, diff_diff/__init__.py:L290, diff_diff/guides/llms-full.txt:L5, pyproject.toml:L7, and rust/Cargo.toml:L3.
  • P2: as written, 3.3.2 is carrying additive public features/APIs, which conflicts with the project’s own SemVer statement in CHANGELOG.md:L5-L6.
  • P3: one ancillary release-collateral script outside the diff still hardcodes v3.3.1, so regenerated marketing output would be stale (carousel/generate_had_carousel.py:L173).

Methodology

  • Severity: None. Impact: No estimator implementation, math, SE/inference logic, assumption checks, or defaults changed in the diff. The items described in CHANGELOG.md:L11-L14 are already documented in the Methodology Registry, including explicit notes/deviations for dCDH by_path and HAD/Yatchew parity behavior (docs/methodology/REGISTRY.md:L641-L675, docs/methodology/REGISTRY.md:L2470-L2503), and the HAD trends_lin × survey_design limitation is already tracked in TODO.md:L105. Concrete fix: None.

Code Quality

  • Severity: None. Impact: The edited files are simple metadata/doc surfaces; no new executable logic or error-handling paths were introduced. Concrete fix: None.

Performance

  • Severity: None. Impact: Metadata and changelog edits do not affect Python or Rust runtime behavior. Concrete fix: None.

Maintainability

  • Severity: P2. Impact: CHANGELOG.md says the project adheres to Semantic Versioning (CHANGELOG.md:L5-L6), but the 3.3.2 entry advertises additive public functionality such as new by_path compatibility/results fields, yatchew_hr_test(null="mean_independence"), and HAD trends_lin (CHANGELOG.md:L11-L13). That makes a patch release behave like a minor release for downstream consumers who rely on patch-version stability. Concrete fix: Either publish this bundle as 3.4.0 and update the version surfaces accordingly, or narrow the 3.3.2 changelog entry to true patch-level changes only.

Tech Debt

  • Severity: None. Impact: The deferred items mentioned by the release notes are already tracked, so this PR does not introduce new untracked technical debt. Concrete fix: None.

Security

  • Severity: None. Impact: No secrets, credentials, or executable security-sensitive code paths are introduced by the diff. Concrete fix: None.

Documentation/Tests

  • Severity: P3. Impact: Outside the edited files, carousel/generate_had_carousel.py:L173 still contains v3.3.1; if that script is rerun for this release, it will emit stale collateral despite the package/release being 3.3.2. This is informational only and does not affect library correctness. Concrete fix: Update the literal to v3.3.2 or source the displayed version from a single canonical version constant.

@igerber igerber added the ready-for-ci Triggers CI test workflows label Apr 26, 2026
@igerber igerber merged commit 33afb6a into main Apr 27, 2026
29 of 30 checks passed
@igerber igerber deleted the release/3.3.2 branch April 27, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-ci Triggers CI test workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant