docs: add retrospective paper reviews for TROP and Wooldridge ETWFE#443
Conversation
Both reviews follow the existing template under docs/methodology/papers/ and back already-shipped estimators (diff_diff/trop.py, diff_diff/wooldridge.py). - athey-2025-review.md — Athey, Imbens, Qu, Viviano (2025) "Triply Robust Panel Estimators" (arXiv:2508.21536) - wooldridge-2023-review.md — Wooldridge (2023) "Simple approaches to nonlinear difference-in-differences with panel data" (Econometrics Journal 26(3), doi:10.1093/ectj/utad016) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Overall Assessment✅ Looks good This is a docs-only PR, so there are no unmitigated P0/P1 findings. The main issues are P2/P3 documentation accuracy problems where the new paper-review files drift from the shipped registry/code. Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
athey-2025-review.md: - Replace contributor-local absolute PDF path with arXiv URL - Note shipped TROP requires absorbing treatment (paper Eq 13 generalization is out of scope for the current implementation) - Rename "twostep"/"joint" to "local"/"global" and correct the global-method description to residual-based treated-cell effects averaged into ATT wooldridge-2023-review.md: - Split delta_2 interpretation by link function (exponential = log diff / proportional effect; logistic = change in log-odds) - Update control_group default to "not_yet_treated" (matches wooldridge.py:305) - Update implementation note: solve_poisson exists at linalg.py:3431 and is used in the Poisson path - Add aggregation deviation note linking to REGISTRY and TODO entries Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
/ai-review |
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
athey-2025-review.md: - Correct "7 real datasets" to "6 real datasets / 7 simulation applications" (CPS is used for both logwage and urate outcomes; paper Table 1 / Section 3 names 6 source datasets) - Rewrite Equation 13 nuclear-norm gap note as a neutral source-based check (remove authoring artifact) wooldridge-2023-review.md: - Surface shipped covariate API (exovar / xtvar / xgvar incl. time-varying via xtvar with demean_covariates default) in Data Structure Requirements and Tuning Parameters table; cross-link to wooldridge.py:394-411 and REGISTRY.md "Covariates" Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
wooldridge-2023-review.md: - Aggregation note: stop attributing "Eqs. 7.2-7.4" to the 2023 paper (the 2023 paper describes aggregation only conceptually in Section 3.1; the formal cohort-share equations are from W2025 per REGISTRY.md) - Implementation Notes: separate paper notation from shipped API. Users provide cohort/first_treat; W_it is constructed internally from cohort+ time via _build_interaction_matrix (wooldridge.py:165-189), not passed as a column - Standard errors: add shipped-API restriction note — n_bootstrap > 0 is OLS-only (wooldridge.py:432-437) and rejected with survey_design (wooldridge.py:441-444) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
athey-2025-review.md: - Relabel balanced-panel bullet as "Paper assumption" and add an adjacent shipped-implementation note that diff_diff/trop.py supports unbalanced panels with structural gaps (matches the later "Unbalanced panels" entry under Gaps and Uncertainties and the corresponding REGISTRY section) wooldridge-2023-review.md: - Treatment exit (Section 7.2) bullet: mark as extension and carry over the paper's additional restriction that future shocks to untreated potential outcomes cannot drive exit - Multiple treatment levels (Section 7.4) bullet: mark as extension; note the paper describes it as relatively straightforward but not fully general, leaving the precise multi-level estimand to future work Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
athey-2025-review.md: - Reframe Methodology Registry Entry intro from "copy into REGISTRY" ready-to-promote to a working-draft framing that explicitly defers promotion until two source-ambiguity items (weight normalization, Eq. 13 penalty form) are resolved against the source - Pull the weight-normalization line out of the Requirements Checklist (it was framed as a settled requirement); restate it as an open source-ambiguity cross-referencing Gap #5, with the current shipped implementation pinned to the Equation 2 (unnormalized) interpretation Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
athey-2025-review.md: - Mark Equation 13 nuclear-norm penalty as resolved (paper text confirms the same unsquared form as Equation 2) - Tighten draft-framing intro: weight normalization is the only remaining open source-ambiguity item wooldridge-2023-review.md: - Replace nonexistent local PDF path with the Econometrics Journal DOI URL so the provenance trail is reproducible from the repo Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
athey-2025-review.md: - Replace generic arXiv abstract URL with a version-pinned v2 link so the reviewed artifact resolves to v2 (the current arXiv record now resolves to v3) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🔁 AI review rerun (requested by @igerber) Head SHA: Overall Assessment ✅ Looks good Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
Summary
Adds two paper-review markdown files under `docs/methodology/papers/`, following the existing template. Both reviews are retrospective documentation for estimators already shipped in the library.
Methodology references (required if estimator / math changes)
Validation
Security / privacy