blind DR3 data with new blinding strategy#1140
Merged
Merged
Conversation
iprafols
approved these changes
May 19, 2026
Collaborator
iprafols
left a comment
iprafols
left a comment
There was a problem hiding this comment.
I'm happy with the changes. These changes should make picca_export crash at line 412, but we should double-check that this is indeed happening
Contributor
Author
|
I've done a quick hack where I have changed (temporarily) the definition of the DR2 / DR3 boundary so that I would get some deltas with DR3 blinding, and I measured correlations from these. They were correctly flagged as blinding = So I think we are good to go! |
Collaborator
|
Agreed, I'll set the merge then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we will start analyzing data from DR3, it is important to blind this properly. We do not have the templates yet, so for now this should just cause the code to crash for any analysis including DR3 data.