Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #93 by adding an environment-driven way to configure HTTP CORS origin validation for the MCP server, with corresponding documentation updates. In the codebase, this affects the server bootstrap path in src/index.ts and the deployment/configuration guidance in README.md.
Changes:
- Add
HTTP_CORS_ALLOWED_ORIGINSparsing in the server startup code and pass it into HTTP transport CORS options. - Emit a warning when the CORS origins variable is not configured.
- Document the new variable in the README and update the table of contents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/index.ts |
Adds env parsing, warning logic, and HTTP transport CORS wiring at server startup. |
README.md |
Documents the new environment variable and updates README navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds CORS origin configuration for HTTP transport to improve security against DNS rebinding and make production deployment safer.
Short Description
HTTP_CORS_ALLOWED_ORIGINSto configure the list of allowed origins in HTTP mode.Why
The current HTTP setup is permissive by default. This PR introduces an explicit, environment-driven way to restrict allowed origins (local, staging, production).
Impact
Example
HTTP_CORS_ALLOWED_ORIGINS="http://localhost:3000,https://geollm.beta.ign.fr"
Reference
Closes #93