Conversation
mborne
reviewed
Apr 8, 2026
Contributor
mborne
left a comment
mborne
left a comment
There was a problem hiding this comment.
gpfWfsListTypesInputSchema to clarify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #31
This pull request enforces strict input validation on all tool input schemas by using Zod's
.strict()method, ensuring that any unexpected arguments are rejected. Additionally, a new test suite is added to verify that each tool properly rejects inputs containing unexpected fields.Input Schema Strictness:
Added
.strict()to all tool input schemas insrc/tools, so any unexpected properties in the input will now cause validation to fail. This change affects the following tools:AdminexpressTool,AltitudeTool,AssietteSupTool,CadastreTool,GeocodeTool,GpfWfsDescribeTypeTool,GpfWfsGetFeaturesTool,GpfWfsListTypesTool,GpfWfsSearchTypesTool, andUrbanismeTool.Testing:
Added a new test file
test/tools/strict-input.test.tsthat systematically checks each tool to ensure it rejects any input containing unexpected arguments, improving reliability and preventing silent acceptance of invalid data.