Conversation
…ypeTool for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #49
This pull request clarifies and strengthens the guidance and error messages related to property name usage in WFS tools. It emphasizes the importance of calling
gpf_wfs_describe_typebefore attempting to access feature properties, and updates error messages and documentation to prevent common mistakes.Error handling improvements:
getPropertyOrThrow(incompile.ts) to explicitly instruct users to callgpf_wfs_describe_typefor available property names, making troubleshooting clearer.Documentation and usage guidance:
GpfWfsGetFeaturesTool, added a mandatory warning to always callgpf_wfs_describe_typebefore using the tool (unless already called for the same typename in the current conversation), and clarified that property names are not guessable and must be retrieved explicitly.GpfWfsDescribeTypeTool, made the documentation more prominent by adding "IMPORTANT:" to the recommendation about calling the tool when property names are unknown.