-
Notifications
You must be signed in to change notification settings - Fork 11
build(deps): bump cosmossdk.io/log to v1.6.1 and ignite/cli to v29.4.0 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! Thanks for PR. Can you instead update cosmossdk.io/log to v1.6.1 |
|
@julienrbrt updated PR |
julienrbrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
can you check the failing tests? |
|
@julienrbrt funny enough its due to the same reason. CLI fixed this in v29.4 but integration tests are using v29.3, ill give it the same treatment and update it everywhere in the repo |
|
could you then bump CLI? |
|
@julienrbrt done |
|
can you unbump cli in the fee abstraction app https://github.com/ignite/apps/actions/runs/17798723794/job/50593911309?pr=226 😬 |
@julienrbrt I could but this would fail for the same reason I bumped it no? go1.25 would not be able to compile cli <v25.4 i dont quite understand why its failing but would it be possible to fix fee abstraction to work with 29.4? |
we should fix it yeah, but this can be done in a follow-up. Or we fix it first and merge main in this. Whatever you prefer. |
@julienrbrt its your repository so it's your choice lol, you could merge it now and ignore the CI failing (it would still fail if i unbumped it), or if you prefer not to do that I can revert the cli bump commit and you can merge it once you fix it and bump cli separately in main |
|
yes, then please revert it but only for the fee abstraction app. we should still bump the other apps. |
|
I was implying that the cli bump be done in another commit/PR with the fee abstraction fix, then we merge this on top of it, but it just occurred to me that even if you do that, that commit would have to be merged bypassing CI too, so idk, maybe i can change the target branch to one other than main and you take it from there? or if you insist ill unbump fee abstraction and you can follow up on fixing it once i reach home |
|
tracked the rest here: #228. it will be done later. |
This is the same issue as ignite/cli#4752 (by proxy from
cosmossdk.io/log@v1.6.0), fixed by upgrading to v1.6.1command used:
log: upgrade-cosmossdk-log.log
confirmation that it builds:
The same problem happened in CI which uses the latest go version when it tried to compile CLI at version v29.1.0, CLI patched this in v29.4.0 so its bumped as well
command:
log: upgrade-ignite-cli.log