fix(pkg/cosmosclient): ensure account has funds after faucet transfer#1846
Merged
fix(pkg/cosmosclient): ensure account has funds after faucet transfer#1846
Conversation
Pantani
approved these changes
Nov 30, 2021
Collaborator
Pantani
left a comment
Pantani
left a comment
There was a problem hiding this comment.
👌🏽
only a question and a suggestion
|
|
||
| return nil | ||
| // make sure funds are retrieved. | ||
| ctx, cancel := context.WithTimeout(ctx, time.Minute) |
Collaborator
There was a problem hiding this comment.
Maybe 1 minute is it not too long to wait?
Contributor
Author
There was a problem hiding this comment.
Is 5mins good? Tho, usually blocks are generated under 30secs, if your node is not behind of the other nodes in the network.
Contributor
Author
There was a problem hiding this comment.
I'll update this to 2 mins and make in configurable.
Collaborator
There was a problem hiding this comment.
I was trying to say 1 min is too much time. If we can reduce it to ~40 seconds can be better for the user experience.
Contributor
Author
There was a problem hiding this comment.
I see now, definitely.
this is useful if tx for faucet transfer not sent in the `sync` mode. * pkg/cosmosclient: improve faucet defaults. * pkg/cosmosfaucet: ensure that transfer tx uses `syncA mode.`
ilgooz
force-pushed
the
fix/cosmosclient
branch
from
fce22f8 to
412c8bd
Compare
lumtis
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is useful if tx for faucet transfer not sent in the
syncmode.syncA mode.