fix(scaffold chain {id}): fixed error handler for generated path copy#1907
Merged
ilgooz merged 1 commit intoignite:developfrom Dec 9, 2021
Merged
fix(scaffold chain {id}): fixed error handler for generated path copy#1907ilgooz merged 1 commit intoignite:developfrom
scaffold chain {id}): fixed error handler for generated path copy#1907ilgooz merged 1 commit intoignite:developfrom
Conversation
When I run `scaffold chain {id}`, it caused `cannot copy path error`.
I found it weird logic to handle error right after copying path from tmp to `appPath`.
I've fixed to return error only if copy causes an error.
hackartists
requested review from
Pantani,
fadeev,
ilgooz,
ivanovpetr and
lumtis
as code owners
Pantani
approved these changes
Dec 8, 2021
Collaborator
Pantani
left a comment
Pantani
left a comment
There was a problem hiding this comment.
Excellent, thanks for catching this!!
ilgooz
approved these changes
Dec 9, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…py (ignite#1907) When I run `scaffold chain {id}`, it caused `cannot copy path error`. I found it weird logic to handle error right after copying path from tmp to `appPath`. I've fixed to return error only if copy causes an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I run
scaffold chain {id}, it causedcannot copy path error.I found it weird logic to handle error right after copying path from tmp to
appPath.I've fixed to return error only if copy causes an error.