Hurl tests with CI#202
Merged
Merged
Conversation
Fishbowler
force-pushed
the
hurl_tests
branch
6 times, most recently
from
8900d82 to
4febbd3
Compare
Fishbowler
force-pushed
the
hurl_tests
branch
2 times, most recently
from
60700f1 to
ebe4ec5
Compare
Fishbowler
force-pushed
the
hurl_tests
branch
from
36c2c8e to
7ab6a6e
Compare
guusdk
reviewed
Nov 11, 2025
|
|
||
| - name: Run Openfire | ||
| uses: igniterealtime/launch-openfire-action@v1.1.2 | ||
| uses: igniterealtime/launch-openfire-action@v1.2.0 |
Member
There was a problem hiding this comment.
Maybe just use @main here? A fixed version is more stable in theory, but whenever we're going to update that action (which is under our control), it is highly likely we want to update all our consumers too.
guusdk
reviewed
Nov 11, 2025
| secrets: | ||
| IGNITE_REALTIME_MAVEN_USERNAME: ${{ secrets.IGNITE_REALTIME_MAVEN_USERNAME }} | ||
| IGNITE_REALTIME_MAVEN_PASSWORD: ${{ secrets.IGNITE_REALTIME_MAVEN_PASSWORD }} | ||
| test: |
Member
There was a problem hiding this comment.
Maybe have a slightly more descriptive name, so that casual onlookers understand what kind of tests are performed?
guusdk
approved these changes
Nov 11, 2025
Member
guusdk
left a comment
guusdk
left a comment
There was a problem hiding this comment.
This looks great to me. I've not looked into the hurl scenarios themselves, but focused on the scaffolding. Left two nitpicking comments, but I'd be happy to merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e test in Hurl, along with CI to run em. Decreases the chances of functional regressions in the future.
Fixes #217
I left some TODO comments for future folk.