Add faraday-encoding to correctly set the response body encoding #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrbnelson
commented
Aug 5, 2021
| activesupport | ||
| builder | ||
| dry-types | ||
| dry-types (~> 0.15.0) |
Member
Author
There was a problem hiding this comment.
A lot of gems upgraded as a result of my bundle install, and dry-types is using an older syntax so needs to be locked to this version.
The tests otherwise pass fine with the other upgrades.
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fix response encoding * rubocop Co-authored-by: Chris Nelson <git@chrisnelson.io>
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fix response encoding * rubocop Co-authored-by: Chris Nelson <git@chrisnelson.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faraday, when backed by
Net::HTTP, doesn't properly set the response encoding based on the server headers. This can lead to errors when trying to serialize that data to JSON further down the stack.The
faraday-encodinggem fixes this.