Skip to content

fix: review issues from PRs #5–#12#13

Merged
ignsm merged 9 commits intomainfrom
fix/review-issues
Apr 7, 2026
Merged

fix: review issues from PRs #5–#12#13
ignsm merged 9 commits intomainfrom
fix/review-issues

Conversation

@ignsm
Copy link
Copy Markdown
Owner

@ignsm ignsm commented Apr 7, 2026

Because we all live in AI-era (today is Apr 7 2026), I've added some features using AI in one batch. But of course I don't trust it all and want to review everything, before really release the thing. So, this PR review code across the last 8 PRs to find ai-slop, bugs, dead code, and style guide violations.

Bugs fixed

  • useFieldOptions (React): async providers had no .catch() — unhandled rejection on network errors, provider never retried. Added error handling + stale effect cleanup.
  • useFieldOptions (Vue): same unhandled rejection issue. Wrapped in try/catch. Replaced deep: true watch with deps-key caching to avoid re-fetching on every keystroke.
  • Validation messages: multiselect minLength/maxLength said "characters" instead of "items" for array values. Fixed default messages + updated tests.

Cleanup

  • Removed unused @vue/test-utils devDependency (tests use @testing-library/vue).

Style guide compliance

  • _dirty_isDirty in FormEngine
  • resolvedPrimaryLabel()getPrimaryLabel() etc. in Vue FormActions (verb-first)
  • showHeader/showHelperhasHeader/hasHelper in Figma renderer
  • Optional chaining in 5 places (schema.fields && schema.fields.lengthschema.fields?.length)
  • Magic numbers extracted to named constants (DEFAULT_ROWS, LABEL_FONT_SIZE, GROUP_SPACING, ROW_SPACING)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
formhaus Ready Ready Preview, Comment Apr 7, 2026 1:59pm

@ignsm ignsm merged commit 6584f25 into main Apr 7, 2026
3 checks passed
@ignsm ignsm deleted the fix/review-issues branch April 7, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant