Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we all live in AI-era (today is Apr 7 2026), I've added some features using AI in one batch. But of course I don't trust it all and want to review everything, before really release the thing. So, this PR review code across the last 8 PRs to find ai-slop, bugs, dead code, and style guide violations.
Bugs fixed
.catch()— unhandled rejection on network errors, provider never retried. Added error handling + stale effect cleanup.deep: truewatch with deps-key caching to avoid re-fetching on every keystroke.minLength/maxLengthsaid "characters" instead of "items" for array values. Fixed default messages + updated tests.Cleanup
@vue/test-utilsdevDependency (tests use@testing-library/vue).Style guide compliance
_dirty→_isDirtyin FormEngineresolvedPrimaryLabel()→getPrimaryLabel()etc. in Vue FormActions (verb-first)showHeader/showHelper→hasHeader/hasHelperin Figma rendererschema.fields && schema.fields.length→schema.fields?.length)DEFAULT_ROWS,LABEL_FONT_SIZE,GROUP_SPACING,ROW_SPACING)