fix(playground): missing AutocompleteField breaks Vuetify/MUI variants#39
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #38 made the default playground fixture (
basic-form.json) use the newautocompletefield type, the Vuetify and MUI playground variants crashed at runtime with:Cause:
examples/vue-vuetify/src/component-map.ts(and the MUI equivalent) registerautocomplete: AutocompleteField, but the Sandpack loaders indocs/.vitepress/components/playground/loaders/weren't updated to ship the new field file. Sandpack-resolved imports point at a file the playground never sent.Fixes
docs/.vitepress/components/playground/loaders/vue-vuetify.tsandreact-mui.tsnow?raw-importAutocompleteFieldand include it in the file map.examples/vanilla-svelte/src/App.svelteextended to handleautocomplete(<input list>+<datalist>) anddatetime(type="datetime-local"). Without this, the Svelte variant fell back to plain<input type="text">for both new types — still functional, but the playground wouldn't actually showcase them.pnpm docs:buildandpnpm --filter @formhaus-examples/vanilla-svelte buildboth clean.