🛡️ Sentinel: [CRITICAL] Key material not zeroed after use#5
Conversation
- Implement `deinit` in `Handshake` struct to securely wipe keys using `std.crypto.secureZero`. - Update `deriveTransportKeys` to wipe ephemeral secrets immediately after use. - Call `handshake.deinit()` in `WgDevice.removePeer` to ensure secrets are cleared when a peer is removed. - Fixes CRITICAL vulnerability: "Key material not zeroed after use". - Verified with unit tests ensuring `deinit` resets state and compiles correctly. Co-authored-by: igorls <4753812+igorls@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses a critical security vulnerability where sensitive key material (static private keys, shared secrets, chaining keys) was left in memory after a handshake session or when a peer was removed.
Changes:
deinitmethod tosrc/wireguard/noise.zig:Handshakewhich usesstd.crypto.secureZeroto wipe all sensitive fields.deriveTransportKeysinsrc/wireguard/noise.zigto securely zero ephemeral secrets (chaining_key,hash,remote_ephemeral) immediately after deriving transport keys.src/wireguard/device.zig:removePeerto callpeer.handshake.deinit()before removing the peer from thepeersarray, ensuring the memory is scrubbed.src/wireguard/noise.zigto verifydeinitfunctionality..jules/sentinel.mdwith the vulnerability finding and fix.This ensures that even if memory is dumped or swapped, long-lived secrets are minimized in memory and ephemeral secrets are discarded promptly.
PR created automatically by Jules for task 5565583968971290168 started by @igorls