Adding chain operators and fixing unsafe macro#19
Merged
Conversation
Owner
|
Hello. Thank you for your PR. Your changes looks interesting. I'm a little busy for a few days to have intent sight on your changes, but I can say that you must revert changes in I will check your changes in a few days, but they looks at least interesting... |
Owner
|
One more thing - use |
igormironchik
requested changes
Mar 19, 2026
Owner
|
I'm waiting for your fixes, and I don't see any problems to not merge it. Thank you for PR. |
igormironchik
requested changes
Mar 19, 2026
Contributor
Author
|
Thanks for the review!! Will make these changes later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the “help” example - basically I wanted to be able to chain these setters together to make a little smoother builder pattern.
Also offering a fix to the doctest string macro which uses an unsafe sprintf call - updating with a recommendation from cpp ref
Thanks for the library! Hopefully you’ll consider this PR.