chore: restore one-value-per-line layout of long enum defaults - #2781
Merged
Conversation
The ellipsis-migration rewriter collapsed multi-line enum defaults into single over-long lines with stray inner spaces, e.g. `type = c( "undirected", ... )` in `transitivity()`, and air leaves them alone because `c` is on its skip list. Restore the original one-value-per-line layout for `transitivity()` and `distances()`, in both the signatures and the migration registry. No behavior change; the generated ARG_HANDLE blocks and Rd usage are deparse-based and stay identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
krlmlr
pushed a commit
that referenced
this pull request
Jul 26, 2026
Same fix as #2781: the migration rewriter collapsed multi-line enum defaults and air skips c() calls, so restore the original layout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
krlmlr
pushed a commit
that referenced
this pull request
Jul 26, 2026
Same fix as #2781: the migration rewriter collapsed multi-line enum defaults and air skips c() calls, so restore the original layout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
krlmlr
pushed a commit
that referenced
this pull request
Jul 26, 2026
Same fix as #2781: the migration rewriter collapsed multi-line enum defaults and air skips c() calls, so restore the original layout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
krlmlr
enabled auto-merge (squash)
July 26, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
transitivity()formatting review on the merged #2759.The defect
The ellipsis-migration rewriter normalized each formal onto one line and
collapsed multi-line enum defaults, producing a 155-character line with stray
inner spaces:
airdid not repair it becausecis onair.toml'sskiplist(intentionally, so data vectors keep their authored layout) — which is also
why this must be fixed by hand rather than by the formatter.
The fix
Restore the pre-migration one-value-per-line layout for the two affected
functions on
main—transitivity()(type) anddistances()(
algorithm) — in both the function signatures(
R/structural-properties.R) and the migration registry(
tools/migrations/structural-properties.R).No behavior change:
(
Rscript tools/generate-migrations.Ris a no-op on this branch);man/*.Rdusage is deparse-based too —devtools::document()produces nodiff;
transitivity()/distances()behavior verified unchanged.The same collapse exists on three not-yet-merged topic branches
(games ×2, conversion ×1, similarity-efficiency ×2 functions);
those branches are being amended directly with the identical layout fix.
Generated by Claude Code