Conversation
maelle
changed the title
| @@ -200,20 +200,14 @@ motifs <- function(graph, size = 3, cut.prob = NULL) { | |||
| count_motifs <- function(graph, size = 3, cut.prob = NULL) { | |||
| ensure_igraph(graph) | |||
There was a problem hiding this comment.
I am on the fence about removing it, because even if that is asserted in the autogenerated function, shouldn't this happen before anything else?
There was a problem hiding this comment.
Could you be more specific? You mean remove the ensure_igraph() call? Maybe for consistency with other functions keep it still?
There was a problem hiding this comment.
@schochastics actually it's not very consistent among functions taking graph as input, from the little I've seen. A new upkeep task! 🤪
There was a problem hiding this comment.
I am actually not surprised 🙈
|
Other comments @schochastics? |
schochastics
left a comment
schochastics
left a comment
There was a problem hiding this comment.
looks good to me :)
|
Thanks! However main is frozen (@krlmlr) so we can merge this after the release. |
krlmlr
changed the title
|
Thanks! |
…)" This reverts commit 2deff97.
3 participants
Note that these high-level functions are tested.