Conversation
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace _impl aliases with explicit wrapper functions in R/centrality.R
Replace Oct 25, 2025
_impl function aliases with explicit wrappers in R/centrality.R
_impl function aliases with explicit wrappers in R/centrality.R_impl function aliases with explicit wrappers in R/centrality.R
krlmlr
added a commit
that referenced
this pull request
Oct 25, 2025
…centrality.R` (#2362) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com> Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct function aliases to
_implfunctions obscure the API surface and make function signatures less discoverable. This replaces four aliases with explicit wrapper functions that forward arguments individually.Changes
strength: Now explicitly wrapsstrength_implwith full signature(graph, vids, mode, loops, weights)diversity: Now explicitly wrapsdiversity_implwith full signature(graph, weights, vids)page_rank: Now explicitly wrapspersonalized_pagerank_implwith full signature(graph, algo, vids, directed, damping, personalized, weights, options)harmonic_centrality: Now explicitly wrapsharmonic_centrality_cutoff_implwith full signature(graph, vids, mode, weights, normalized, cutoff)Each wrapper forwards arguments using explicit
arg = argnotation, consistent with existing deprecated wrapper patterns in the file (e.g.,graph.strength,page.rank).Example
Before:
After:
Original prompt
_implaliases inR/centrality.R#2335💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.