Skip to content

refactor: Replace _impl aliases with explicit wrapper functions in R/triangles.R#2369

Merged
krlmlr merged 5 commits intomainfrom
copilot/replace-impl-aliases-in-triangles
Oct 25, 2025
Merged

refactor: Replace _impl aliases with explicit wrapper functions in R/triangles.R#2369
krlmlr merged 5 commits intomainfrom
copilot/replace-impl-aliases-in-triangles

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 25, 2025

Replaces direct _impl function aliases with explicit wrapper functions for better code clarity and maintainability.

Changes:

  • triangles: Now an explicit wrapper forwarding graph parameter to list_triangles_impl()
  • count_triangles: Now an explicit wrapper forwarding graph and vids parameters to count_adjacent_triangles_impl()

Before:

triangles <- list_triangles_impl
count_triangles <- count_adjacent_triangles_impl

After:

triangles <- function(graph) {
  list_triangles_impl(
    graph = graph
  )
}

count_triangles <- function(graph, vids = V(graph)) {
  count_adjacent_triangles_impl(
    graph = graph,
    vids = vids
  )
}

Arguments are forwarded explicitly using arg = arg notation. Function signatures and behavior remain unchanged.

Original prompt

This section details on the original issue you should resolve

<issue_title>Replace _impl aliases in R/triangles.R</issue_title>
<issue_description>Goal
Review the code in R/triangles.R and replace all direct _impl function aliases with explicit wrapper functions.

Functions to update:

  • triangles <- list_triangles_impl
  • count_triangles <- count_adjacent_triangles_impl

Instructions

  1. Review the code to understand the function signatures
  2. Create explicit wrapper functions that forward to the _impl functions
  3. Forward each argument individually and explicitly using arg = arg notation
  4. Do not use ... unless the _impl function itself uses ...

Pattern
Replace direct aliasing like:

func_name <- func_name_impl

With an explicit wrapper:

func_name <- function(arg1, arg2, ...) {
  func_name_impl(
    arg1 = arg1,
    arg2 = arg2,
    ...
  )
}

File
R/triangles.R</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…angles.R`

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace _impl aliases in R/triangles.R Replace _impl aliases with explicit wrapper functions in R/triangles.R Oct 25, 2025
Copilot AI requested a review from krlmlr October 25, 2025 16:47
@krlmlr krlmlr changed the title Replace _impl aliases with explicit wrapper functions in R/triangles.R chore: Replace _impl aliases with explicit wrapper functions in R/triangles.R Oct 25, 2025
@krlmlr krlmlr changed the title chore: Replace _impl aliases with explicit wrapper functions in R/triangles.R refactor: Replace _impl aliases with explicit wrapper functions in R/triangles.R Oct 25, 2025
@krlmlr krlmlr marked this pull request as ready for review October 25, 2025 17:06
@krlmlr krlmlr enabled auto-merge (squash) October 25, 2025 17:06
@krlmlr krlmlr disabled auto-merge October 25, 2025 20:40
@krlmlr krlmlr merged commit 885b1c7 into main Oct 25, 2025
5 of 6 checks passed
@krlmlr krlmlr deleted the copilot/replace-impl-aliases-in-triangles branch October 25, 2025 20:40
krlmlr added a commit that referenced this pull request Oct 25, 2025
…`R/triangles.R` (#2369)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace _impl aliases in R/triangles.R

2 participants