Skip to content

refactor: replace sir <- sir_impl alias with explicit wrapper#2370

Merged
krlmlr merged 5 commits intomainfrom
copilot/replace-impl-aliases-in-r-sir
Oct 25, 2025
Merged

refactor: replace sir <- sir_impl alias with explicit wrapper#2370
krlmlr merged 5 commits intomainfrom
copilot/replace-impl-aliases-in-r-sir

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 25, 2025

Replace direct function aliasing with explicit wrapper in R/sir.R to make the interface more maintainable and consistent with the rest of the codebase.

Changes

  • Replace sir <- sir_impl with explicit wrapper function
  • Forward all arguments individually: graph, beta, gamma, no.sim

Before:

sir <- sir_impl

After:

sir <- function(graph, beta, gamma, no.sim = 100) {
  sir_impl(
    graph = graph,
    beta = beta,
    gamma = gamma,
    no.sim = no.sim
  )
}

This pattern matches other wrappers in the codebase (e.g., assortativity_nominal) and makes function signatures explicit in the source code.

Original prompt

This section details on the original issue you should resolve

<issue_title>Replace _impl aliases in R/sir.R</issue_title>
<issue_description>Goal
Review the code in R/sir.R and replace all direct _impl function aliases with explicit wrapper functions.

Functions to update:

  • sir <- sir_impl

Instructions

  1. Review the code to understand the function signatures
  2. Create explicit wrapper functions that forward to the _impl functions
  3. Forward each argument individually and explicitly using arg = arg notation
  4. Do not use ... unless the _impl function itself uses ...

Pattern
Replace direct aliasing like:

func_name <- func_name_impl

With an explicit wrapper:

func_name <- function(arg1, arg2, ...) {
  func_name_impl(
    arg1 = arg1,
    arg2 = arg2,
    ...
  )
}

File
R/sir.R</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Oct 25, 2025
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace _impl aliases with explicit wrappers in R/sir.R refactor: replace sir <- sir_impl alias with explicit wrapper Oct 25, 2025
Copilot AI requested a review from krlmlr October 25, 2025 16:45
@krlmlr krlmlr marked this pull request as ready for review October 25, 2025 17:04
@krlmlr krlmlr enabled auto-merge (squash) October 25, 2025 17:05
@krlmlr krlmlr disabled auto-merge October 25, 2025 20:39
@krlmlr krlmlr merged commit ceec68d into main Oct 25, 2025
5 of 6 checks passed
@krlmlr krlmlr deleted the copilot/replace-impl-aliases-in-r-sir branch October 25, 2025 20:39
krlmlr added a commit that referenced this pull request Oct 25, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace _impl aliases in R/sir.R

2 participants