Skip to content

refactor: Replace _impl aliases with explicit wrappers in R/trees.R#2373

Merged
krlmlr merged 3 commits intomainfrom
copilot/replace-impl-aliases
Oct 25, 2025
Merged

refactor: Replace _impl aliases with explicit wrappers in R/trees.R#2373
krlmlr merged 3 commits intomainfrom
copilot/replace-impl-aliases

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 25, 2025

Replaces direct _impl function aliases with explicit wrapper functions for improved code consistency and maintainability.

Changes:

  • is_forest <- is_forest_impl → explicit wrapper forwarding graph, mode, details
  • to_prufer <- to_prufer_impl → explicit wrapper forwarding graph

Pattern:

# Before
is_forest <- is_forest_impl

# After
is_forest <- function(graph, mode = c("out", "in", "all", "total"), details = FALSE) {
  is_forest_impl(
    graph = graph,
    mode = mode,
    details = details
  )
}

Follows the established convention from R/assortativity.R and other files. All arguments forwarded explicitly without using ....

Original prompt

This section details on the original issue you should resolve

<issue_title>Replace _impl aliases in R/trees.R</issue_title>
<issue_description>Goal
Review the code in R/trees.R and replace all direct _impl function aliases with explicit wrapper functions.

Functions to update:

  • is_forest <- is_forest_impl
  • to_prufer <- to_prufer_impl

Instructions

  1. Review the code to understand the function signatures
  2. Create explicit wrapper functions that forward to the _impl functions
  3. Forward each argument individually and explicitly using arg = arg notation
  4. Do not use ... unless the _impl function itself uses ...

Pattern
Replace direct aliasing like:

func_name <- func_name_impl

With an explicit wrapper:

func_name <- function(arg1, arg2, ...) {
  func_name_impl(
    arg1 = arg1,
    arg2 = arg2,
    ...
  )
}

File
R/trees.R</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace _impl aliases in R/trees.R Replace _impl aliases with explicit wrappers in R/trees.R Oct 25, 2025
Copilot AI requested a review from krlmlr October 25, 2025 16:46
@krlmlr krlmlr changed the title Replace _impl aliases with explicit wrappers in R/trees.R refactor: Replace _impl aliases with explicit wrappers in R/trees.R Oct 25, 2025
@krlmlr krlmlr marked this pull request as ready for review October 25, 2025 17:05
@krlmlr krlmlr enabled auto-merge (squash) October 25, 2025 17:05
@krlmlr krlmlr merged commit 9bf40ca into main Oct 25, 2025
6 checks passed
@krlmlr krlmlr deleted the copilot/replace-impl-aliases branch October 25, 2025 18:07
krlmlr added a commit that referenced this pull request Oct 25, 2025
…R` (#2373)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace _impl aliases in R/trees.R

2 participants