Skip to content

refactor: replace are_adjacent alias with explicit wrapper in R/structure.info.R#2374

Merged
krlmlr merged 3 commits intomainfrom
copilot/replace-impl-aliases-structure-info
Oct 25, 2025
Merged

refactor: replace are_adjacent alias with explicit wrapper in R/structure.info.R#2374
krlmlr merged 3 commits intomainfrom
copilot/replace-impl-aliases-structure-info

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 25, 2025

Replaces direct _impl function aliasing with an explicit wrapper that forwards arguments individually.

Change

  • are_adjacent <- are_adjacent_impl → explicit wrapper function with named argument forwarding

Before

are_adjacent <- are_adjacent_impl

After

are_adjacent <- function(graph, v1, v2) {
  are_adjacent_impl(
    graph = graph,
    v1 = v1,
    v2 = v2
  )
}

Makes the function signature explicit while maintaining complete backward compatibility.

Original prompt

This section details on the original issue you should resolve

<issue_title>Replace _impl aliases in R/structure.info.R</issue_title>
<issue_description>Goal
Review the code in R/structure.info.R and replace all direct _impl function aliases with explicit wrapper functions.

Functions to update:

  • are_adjacent <- are_adjacent_impl

Instructions

  1. Review the code to understand the function signatures
  2. Create explicit wrapper functions that forward to the _impl functions
  3. Forward each argument individually and explicitly using arg = arg notation
  4. Do not use ... unless the _impl function itself uses ...

Pattern
Replace direct aliasing like:

func_name <- func_name_impl

With an explicit wrapper:

func_name <- function(arg1, arg2, ...) {
  func_name_impl(
    arg1 = arg1,
    arg2 = arg2,
    ...
  )
}

File
R/structure.info.R</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace _impl aliases in R/structure.info.R refactor: replace are_adjacent alias with explicit wrapper in R/structure.info.R Oct 25, 2025
Copilot AI requested a review from krlmlr October 25, 2025 17:00
@krlmlr krlmlr marked this pull request as ready for review October 25, 2025 17:04
@krlmlr krlmlr enabled auto-merge (squash) October 25, 2025 17:04
@krlmlr krlmlr merged commit 0ee6f4b into main Oct 25, 2025
6 checks passed
@krlmlr krlmlr deleted the copilot/replace-impl-aliases-structure-info branch October 25, 2025 18:22
krlmlr added a commit that referenced this pull request Oct 25, 2025
…ructure.info.R` (#2374)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace _impl aliases in R/structure.info.R

2 participants