refactor: Replace _impl aliases with explicit wrappers in R/embedding.R#2380
Merged
refactor: Replace _impl aliases with explicit wrappers in R/embedding.R#2380
_impl aliases with explicit wrappers in R/embedding.R#2380Conversation
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace _impl aliases in R/embedding.R with explicit wrappers
Replace Oct 25, 2025
_impl aliases with explicit wrappers in R/embedding.R
_impl aliases with explicit wrappers in R/embedding.R_impl aliases with explicit wrappers in R/embedding.R
krlmlr
added a commit
that referenced
this pull request
Oct 25, 2025
…ing.R` (#2380) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com> Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces direct
_implfunction aliases with explicit wrapper functions that forward arguments individually.Changes
embed_adjacency_matrix: Replaced alias with wrapper forwarding 7 parameters (graph,no,weights,which,scaled,cvec,options)dim_select: Replaced alias with wrapper forwarding single parameter (sv)embed_laplacian_matrix: Replaced alias with wrapper forwarding 7 parameters (graph,no,weights,which,type,scaled,options)Example
Before:
After:
All wrappers use explicit
arg = argnotation. Function signatures match their corresponding_implfunctions exactly.Original prompt
_implaliases inR/embedding.R#2345✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.