Skip to content

refactor: Replace _impl alias with explicit wrapper in R/layout.R#2382

Merged
krlmlr merged 5 commits intomainfrom
copilot/replace-impl-aliases-layout-r
Oct 25, 2025
Merged

refactor: Replace _impl alias with explicit wrapper in R/layout.R#2382
krlmlr merged 5 commits intomainfrom
copilot/replace-impl-aliases-layout-r

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 25, 2025

Replaced direct _impl function aliasing with an explicit wrapper function to improve code clarity and maintainability.

Changes

  • Converted align_layout <- layout_align_impl to an explicit wrapper function that forwards arguments individually using arg = arg notation

Before

align_layout <- layout_align_impl

After

align_layout <- function(graph, layout) {
  layout_align_impl(
    graph = graph,
    layout = layout
  )
}

This makes the function signature explicit and follows the pattern established elsewhere in the codebase for wrapping implementation functions.

Original prompt

This section details on the original issue you should resolve

<issue_title>Replace _impl aliases in R/layout.R</issue_title>
<issue_description>Goal
Review the code in R/layout.R and replace all direct _impl function aliases with explicit wrapper functions.

Functions to update:

  • align_layout <- layout_align_impl

Instructions

  1. Review the code to understand the function signatures
  2. Create explicit wrapper functions that forward to the _impl functions
  3. Forward each argument individually and explicitly using arg = arg notation
  4. Do not use ... unless the _impl function itself uses ...

Pattern
Replace direct aliasing like:

func_name <- func_name_impl

With an explicit wrapper:

func_name <- function(arg1, arg2, ...) {
  func_name_impl(
    arg1 = arg1,
    arg2 = arg2,
    ...
  )
}

File
R/layout.R</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace _impl aliases in R/layout.R Replace _impl alias with explicit wrapper in R/layout.R Oct 25, 2025
Copilot AI requested a review from krlmlr October 25, 2025 17:33
@krlmlr krlmlr changed the title Replace _impl alias with explicit wrapper in R/layout.R refactor: Replace _impl alias with explicit wrapper in R/layout.R Oct 25, 2025
@krlmlr krlmlr marked this pull request as ready for review October 25, 2025 17:41
@krlmlr krlmlr enabled auto-merge (squash) October 25, 2025 17:41
@krlmlr krlmlr disabled auto-merge October 25, 2025 20:39
@krlmlr krlmlr merged commit 9d00229 into main Oct 25, 2025
5 of 6 checks passed
@krlmlr krlmlr deleted the copilot/replace-impl-aliases-layout-r branch October 25, 2025 20:40
krlmlr added a commit that referenced this pull request Oct 25, 2025
…#2382)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace _impl aliases in R/layout.R

2 participants