refactor: Replace _impl alias with explicit wrapper in R/layout.R#2382
Merged
refactor: Replace _impl alias with explicit wrapper in R/layout.R#2382
_impl alias with explicit wrapper in R/layout.R#2382Conversation
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace _impl aliases in R/layout.R
Replace Oct 25, 2025
_impl alias with explicit wrapper in R/layout.R
_impl alias with explicit wrapper in R/layout.R_impl alias with explicit wrapper in R/layout.R
krlmlr
added a commit
that referenced
this pull request
Oct 25, 2025
…#2382) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com> Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced direct
_implfunction aliasing with an explicit wrapper function to improve code clarity and maintainability.Changes
align_layout <- layout_align_implto an explicit wrapper function that forwards arguments individually usingarg = argnotationBefore
After
This makes the function signature explicit and follows the pattern established elsewhere in the codebase for wrapping implementation functions.
Original prompt
_implaliases inR/layout.R#2351💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.