refactor: Replace _impl aliases with explicit wrapper functions in R/games.R#2383
Merged
refactor: Replace _impl aliases with explicit wrapper functions in R/games.R#2383
_impl aliases with explicit wrapper functions in R/games.R#2383Conversation
Contributor
|
@copilot: Proceed. |
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Contributor
Author
Done! All 11 |
Copilot
AI
changed the title
[WIP] Replace _impl aliases with explicit wrapper functions
Replace Oct 25, 2025
_impl aliases with explicit wrapper functions in R/games.R
_impl aliases with explicit wrapper functions in R/games.R_impl aliases with explicit wrapper functions in R/games.R
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced all 11 direct
_implfunction aliases inR/games.Rwith explicit wrapper functions that forward arguments individually.Changes Made
All functions now use explicit wrappers instead of direct aliasing:
sample_growing- forwards:n,m,...,directed,citationsample_sbm- forwards:n,pref.matrix,block.sizes,directed,loopssample_dot_product- forwards:vecs,directedsample_islands- forwards:islands.n,islands.size,islands.pin,n.intersample_k_regular- forwards:no.of.nodes,k,directed,multiplesample_chung_lu- forwards:out.weights,in.weights,...,loops,variantsample_fitness- forwards:no.of.edges,fitness.out,fitness.in,loops,multiplesample_fitness_pl- forwards:no.of.nodes,no.of.edges,exponent.out,exponent.in,loops,multiple,finite.size.correctionsample_forestfire- forwards:nodes,fw.prob,bw.factor,ambs,directedsample_correlated_gnp- forwards:old.graph,corr,p,permutationsample_correlated_gnp_pair- forwards:n,corr,p,directed,permutationEach wrapper explicitly forwards arguments using
arg = argnotation. The...parameter is only used where the function signature requires it (sample_growingandsample_chung_lu).Testing
devtools::document()Fixes #2348
Original prompt
_implaliases inR/games.R#2348💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.