refactor: Replace _impl aliases with explicit wrapper functions in R/make.R#2384
Merged
refactor: Replace _impl aliases with explicit wrapper functions in R/make.R#2384
_impl aliases with explicit wrapper functions in R/make.R#2384Conversation
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace _impl aliases in R/make.R
Replace Oct 25, 2025
_impl aliases with explicit wrapper functions in R/make.R
_impl aliases with explicit wrapper functions in R/make.R_impl aliases with explicit wrapper functions in R/make.R
krlmlr
added a commit
that referenced
this pull request
Oct 25, 2025
…`R/make.R` (#2384) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com> Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced direct
_implfunction aliasing with explicit wrapper functions to improve code clarity and maintainability.Changes
sample_tree: Now explicitly wrapstree_game_impl()with parametersn,directed,methodmake_from_prufer: Now explicitly wrapsfrom_prufer_impl()with parameterpruferrealize_degseq: Now explicitly wrapsrealize_degree_sequence_impl()with parametersout.deg,in.deg,allowed.edge.types,methodAll wrappers forward arguments individually using
arg = argnotation per project conventions.Before
After
Original prompt
_implaliases inR/make.R#2352💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.