Skip to content

refactor: Replace _impl aliases in R/other.R#2388

Merged
krlmlr merged 6 commits intomainfrom
copilot/replace-impl-aliases-in-other-r
Oct 26, 2025
Merged

refactor: Replace _impl aliases in R/other.R#2388
krlmlr merged 6 commits intomainfrom
copilot/replace-impl-aliases-in-other-r

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 25, 2025

  • Review convex_hull_2d_impl function signature
  • Replace direct alias convex_hull <- convex_hull_2d_impl with explicit wrapper
  • Run tests to verify the change works correctly
  • Format code with air format .
  • Run final tests to ensure everything still works
Original prompt

This section details on the original issue you should resolve

<issue_title>Replace _impl aliases in R/other.R</issue_title>
<issue_description>Goal
Review the code in R/other.R and replace all direct _impl function aliases with explicit wrapper functions.

Functions to update:

  • convex_hull <- convex_hull_2d_impl

Instructions

  1. Review the code to understand the function signatures
  2. Create explicit wrapper functions that forward to the _impl functions
  3. Forward each argument individually and explicitly using arg = arg notation
  4. Do not use ... unless the _impl function itself uses ...

Pattern
Replace direct aliasing like:

func_name <- func_name_impl

With an explicit wrapper:

func_name <- function(arg1, arg2, ...) {
  func_name_impl(
    arg1 = arg1,
    arg2 = arg2,
    ...
  )
}

File
R/other.R</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits October 25, 2025 17:32
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Oct 25, 2025

@copilot: Please proceed.

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Oct 25, 2025

@copilot: Remove the unrelated .gitignore change.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 25, 2025

@copilot: Please proceed.

Completed! The convex_hull <- convex_hull_2d_impl direct alias has been replaced with an explicit wrapper function that forwards the data argument. All tests pass (6952 passed, 2 skipped). The change is in commit 69172a9.

@krlmlr krlmlr marked this pull request as ready for review October 25, 2025 23:43
@krlmlr krlmlr enabled auto-merge (squash) October 25, 2025 23:43
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
auto-merge was automatically disabled October 26, 2025 00:06

Head branch was pushed to by a user without write access

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 26, 2025

@copilot: Remove the unrelated .gitignore change.

Removed the unrelated .gitignore change in commit d5811cb.

@krlmlr krlmlr enabled auto-merge (squash) October 26, 2025 07:50
@krlmlr krlmlr changed the title [WIP] Replace _impl aliases in R/other.R refactor: Replace _impl aliases in R/other.R Oct 26, 2025
@krlmlr krlmlr disabled auto-merge October 26, 2025 07:51
@krlmlr krlmlr enabled auto-merge (squash) October 26, 2025 07:51
@krlmlr krlmlr merged commit 9be22fd into main Oct 26, 2025
4 of 5 checks passed
@krlmlr krlmlr deleted the copilot/replace-impl-aliases-in-other-r branch October 26, 2025 08:15
krlmlr added a commit that referenced this pull request Oct 26, 2025
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace _impl aliases in R/other.R

2 participants