Conversation
…_()` as the call Agent-Logs-Url: https://github.com/igraph/rigraph/sessions/17961799-fea0-41bd-ab97-af4b4fdf2dd0 Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
…ribution Agent-Logs-Url: https://github.com/igraph/rigraph/sessions/14531798-aa2e-466a-b24e-54f954fda365 Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
krlmlr
April 9, 2026 12:18
View session
Contributor
|
@copilot: Keep the signature of expored functions unchanged. |
…ally Agent-Logs-Url: https://github.com/igraph/rigraph/sessions/04af0571-371f-4279-af4a-d5d47ea110b8 Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Contributor
Author
Fixed in 9f300a8. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
with_vertex_()orwith_edge_()passed an invalid-length attribute value insidemake_(), the error message showed an internal helper function rather than the user-facingmake_().Changes Made
R/make.R: Passrlang::current_env()(notsys.call()) frommake_()to.apply_modifiers(). Use internali_set_vertex_attr()/i_set_edge_attr()directly in.apply_modifiers()so the call environment can be forwarded without touching exported function signatures.R/attributes.R: Fixcli_abort(.call = ...)→cli_abort(call = ...)(.callis not a parameter ofcli_abort). Inset_vertex_attr(),set_vertex_attrs(), andset_edge_attr(), capturerlang::current_env()as a local variable rather than adding acallparameter to the exported signatures.Testing
make_(…, with_vertex_(color = 1:2))→Error in 'make_()':✅make_(…, with_edge_(color = 1:2))→Error in 'make_()':✅set_vertex_attr(g, …)→Error in 'set_vertex_attr()':✅set_edge_attr(g, …)→Error in 'set_edge_attr()':✅GitHub Copilot was used to prepare this PR.