chore: implicit assignments#2664
Merged
Merged
Conversation
maelle
commented
May 26, 2026
| for (k in 1:nMerge) { | ||
| x <- merges[k, 1:2] | ||
| if (any(neg <- x >= 0)) { | ||
| neg <- (x >= 0) |
Contributor
Author
There was a problem hiding this comment.
@krlmlr @schochastics small hackathon topic?
Contributor
There was a problem hiding this comment.
Naming is hard, but Claude knows how. Is there more substance to discuss?
Contributor
Author
There was a problem hiding this comment.
well not having this named neg would be better for sure
maelle
commented
May 26, 2026
| mode(arg), | ||
| list = temp <- arg, | ||
| character = return(.igraph.pars[arg]), | ||
|
|
Contributor
Author
There was a problem hiding this comment.
maybe we can add an exception comment instead but I have to say I had trouble understanding the switch() call.
Contributor
There was a problem hiding this comment.
IMHO switch only makes sense if it is more than 2 option OR if we expect that the list of options might grow in the future.
Independently, I also find this statement confusing
schochastics
approved these changes
Jun 4, 2026
krlmlr
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2652