Skip to content

fix: touchstone empty results table for branches with a slash #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schochastics merged 1 commit into from
Jun 4, 2026
+8 −1
Merged

fix: touchstone empty results table for branches with a slash #2689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/touchstone-receive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@ jobs:
cache-version: 1
benchmarking_repo: ${{ matrix.config.benchmarking_repo }}
benchmarking_ref: ${{ matrix.config.benchmarking_ref }}
benchmarking_path: ${{ matrix.config.benchmarking_path }}
benchmarking_path: ${{ matrix.config.benchmarking_path }}
force_upstream: true
r-version: ${{ matrix.config.r }}
# Install the {touchstone} R package from the same commit as the
# action above. The default ('@v1') predates the fix that encodes
# filesystem-unsafe characters in branch names, so head branches with
# a "/" (e.g. feat/foo) get stored as a nested records/<bench>/feat/foo
# directory; benchmark_analyze() then can't match base+head and
# silently drops every benchmark, producing an empty results table.
touchstone_ref: "@7e6072a25d1f8d72649188bc711113039ef94b75"
Loading