Skip to content

Implement draft-16 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igrigorik merged 8 commits into from
Feb 3, 2015
Merged

Implement draft-16 #28

igrigorik merged 8 commits into from
Feb 3, 2015

Conversation

@mad-p
Copy link
Collaborator

@mad-p mad-p commented Jan 26, 2015

Re: #25, #26

draft-15 changes

  • Add http_1_1_required error code

draft-16 changes

  • PRIORITY can be sent/received in any state
  • Update hpack-test-case to lastest (though no normative changes included)
  • Examples advertise h2-16

Bugs found in added tests are fixed, too.

@coveralls
Copy link

coveralls commented Jan 26, 2015

Coverage Status

Coverage increased (+0.01%) to 98.09% when pulling 232e518 on lepidum:h2-16 into be18b18 on igrigorik:master.

igrigorik
igrigorik reviewed Jan 27, 2015
View reviewed changes
lib/http/2/stream.rb Outdated
Copy link
Owner

@igrigorik igrigorik Jan 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop the TODO now, correct?

Copy link
Collaborator Author

@mad-p mad-p Feb 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@coveralls
Copy link

coveralls commented Feb 3, 2015

Coverage Status

Coverage increased (+0.01%) to 98.09% when pulling fc15afa on lepidum:h2-16 into be18b18 on igrigorik:master.

igrigorik added a commit that referenced this pull request Feb 3, 2015
@igrigorik
Merge pull request #28 from lepidum/h2-16
f443c38 
Implement draft-16
@igrigorik igrigorik merged commit f443c38 into igrigorik:master Feb 3, 2015
@igrigorik
Copy link
Owner

igrigorik commented Feb 3, 2015

awesome work, as usual! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mad-p @coveralls @igrigorik