Skip to content

Conversation

@Krajovy
Copy link
Contributor

@Krajovy Krajovy commented Feb 24, 2025

No description provided.

@zenseii zenseii added improvement New feature, request or improvement translation Things related to languages and translations labels Feb 24, 2025
@zenseii zenseii added this to the 1.1.7 milestone Feb 24, 2025
@zenseii zenseii requested a review from Branikolog February 24, 2025 15:46
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Krajovy. Thank you for this contribution. I left some comments. Please have a look.

@zenseii zenseii changed the title Update be.po Update the Belarusian Translation Feb 26, 2025
I corrected the above mentioned by the @zenseii, and also added more text.
@zenseii zenseii self-requested a review February 26, 2025 21:07
@Krajovy
Copy link
Contributor Author

Krajovy commented Mar 2, 2025

@zenseii I still haven't figured out what other code changes are needed?

@zenseii
Copy link
Collaborator

zenseii commented Mar 2, 2025

@zenseii I still haven't figured out what other code changes are needed?

Hi, @Krajovy. You added a lot of new translations and this takes time for the team to review. We will comment here once we have finished reviewing and I would suggest to not add anything new here in the meantime. If you want to continue translating and you are familiar with how git works, then you can open a new branch and continue your work there.

Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Krajovy, I put multiple comments here. Would you mind to take a look at them?

@ihhub
Copy link
Owner

ihhub commented Mar 10, 2025

Hi @Krajovy , could you please revert the last commit as this pull request became too big to review? Let's focus only on existing lines which we reviewed. Then in a next pull request we review the other portion.

@Krajovy
Copy link
Contributor Author

Krajovy commented Mar 10, 2025

Hi @Krajovy , could you please revert the last commit as this pull request became too big to review? Let's focus only on existing lines which we reviewed. Then in a next pull request we review the other portion.

I don't really understand the GitHub interface. Could you please tell me how to do this?

@ihhub
Copy link
Owner

ihhub commented Mar 12, 2025

Hi @Krajovy , I did this for you. GitHub does not allow to do this within the website.

@ihhub
Copy link
Owner

ihhub commented Mar 12, 2025

@Krajovy , let's just fix the existing lines without touching ' symbol.

@ihhub ihhub modified the milestones: 1.1.7, 1.1.8 Mar 23, 2025
@ihhub ihhub removed the request for review from Branikolog April 30, 2025 06:01
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihhub, I left some questions. Please have a look.

@ihhub ihhub requested a review from zenseii April 30, 2025 10:37
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments about apostrophes.

@ihhub ihhub requested a review from zenseii May 1, 2025 03:34
@ihhub ihhub merged commit 825a14b into ihhub:master May 1, 2025
22 checks passed
@ihhub
Copy link
Owner

ihhub commented May 1, 2025

@Krajovy , thank you very much for your contribution to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement New feature, request or improvement translation Things related to languages and translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants