Replace "gold only" chest dialog with "gold or exp" one in case when hero has no space for an artifact #9607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ihhub
added
improvement
ihhub
requested changes
Mar 8, 2025
Owner
ihhub
left a comment
ihhub
left a comment
There was a problem hiding this comment.
Hi @roman-yagodin , I left few comments here. Could you please take a look when you have time?
Contributor
Author
|
OK, sure. |
in case when hero has no space for an artifact
- pass gold param via reference, - standardize msg var declaration, - move function code up the source
roman-yagodin
force-pushed
the
issue-9546
branch
from
116bbb1 to
6aeb707
Compare
Owner
|
Hi @roman-yagodin , if you would be able to update the pull request by today then we can merge it to the upcoming release. |
…no place for an artifact
ihhub
approved these changes
Apr 25, 2025
oleg-derevenetz
requested changes
Apr 25, 2025
Collaborator
oleg-derevenetz
left a comment
oleg-derevenetz
left a comment
There was a problem hiding this comment.
Hi @roman-yagodin I've left some comments, could you take a look at them as soon as you have some free time?
oleg-derevenetz
approved these changes
Apr 28, 2025
ihhub
approved these changes
Apr 30, 2025
Owner
|
@roman-yagodin and @oleg-derevenetz , thank you so much for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #9546.