Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Comments

added RelationDespawnMarker, rollback UnsetAsymmetric command changes#26

Open
aggyomfg wants to merge 4 commits intoiiYese:mainfrom
aggyomfg:edges_cleanup_fix
Open

added RelationDespawnMarker, rollback UnsetAsymmetric command changes#26
aggyomfg wants to merge 4 commits intoiiYese:mainfrom
aggyomfg:edges_cleanup_fix

Conversation

@aggyomfg
Copy link
Contributor

@aggyomfg aggyomfg commented Jan 23, 2025

Hello! Looks like I messed up in #25 :)

My main problem that I tried to solve initially was to use relations that can point each other (and first that I faced - was event duplication, but this wasn't root cause), later I get in situation when i unset relations from entity_a, it also unsets from entity_b (if they points each-other). And I found that we remove Hosts/Targets in UnsetAsymmetric command when they are empty, and this triggers on_remove hooks. But this doesnt fit for Orphan/Counted, so I added RelationDespawnMarker for this types with same hook.

still work in progress

@aggyomfg aggyomfg marked this pull request as draft January 23, 2025 14:42
@aggyomfg
Copy link
Contributor Author

Now I think it's ready for review, I rolled back UnsetAsymmetric #25 changes (but removed target_exists checks, cause it make no sense and broke some event type)

And improved tests to check all this scenarios.

@aggyomfg aggyomfg marked this pull request as ready for review January 25, 2025 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant