This repository was archived by the owner on Jun 3, 2025. It is now read-only.
added RelationDespawnMarker, rollback UnsetAsymmetric command changes#26
Open
aggyomfg wants to merge 4 commits intoiiYese:mainfrom
Open
added RelationDespawnMarker, rollback UnsetAsymmetric command changes#26aggyomfg wants to merge 4 commits intoiiYese:mainfrom
aggyomfg wants to merge 4 commits intoiiYese:mainfrom
Conversation
Contributor
Author
|
Now I think it's ready for review, I rolled back And improved tests to check all this scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Looks like I messed up in #25 :)
My main problem that I tried to solve initially was to use relations that can point each other (and first that I faced - was event duplication, but this wasn't root cause), later I get in situation when i unset relations from entity_a, it also unsets from entity_b (if they points each-other). And I found that we remove Hosts/Targets in
UnsetAsymmetriccommand when they are empty, and this triggers on_remove hooks. But this doesnt fit for Orphan/Counted, so I addedRelationDespawnMarkerfor this types with same hook.still work in progress