Skip to content

Conversation

@glatterf42
Copy link
Member

#281 renamed the environment variable for the python version of our snapshot CI test from python to python-version. The uv action could not find env.python and thus saw no input for python-version, which it needs to create a venv. And without a venv, we get the error we see in today's snapshot CI test.

This PR adjust the name of the environment variable used for the uv action.

How to review

  • Read the diff and note that the variable name used now is correct.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update doc/whatsnew. Just CI.

@glatterf42 glatterf42 added the ci Continuous integration & testing label Jan 23, 2025
@glatterf42 glatterf42 self-assigned this Jan 23, 2025
@glatterf42 glatterf42 requested a review from khaeru as a code owner January 23, 2025 07:31
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.7%. Comparing base (3fe0467) to head (f436bfd).
Report is 296 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #283   +/-   ##
=====================================
  Coverage   76.7%   76.7%           
=====================================
  Files        211     211           
  Lines      16108   16108           
=====================================
  Hits       12363   12363           
  Misses      3745    3745           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@glatterf42 glatterf42 merged commit 29ec892 into main Jan 23, 2025
31 checks passed
@glatterf42 glatterf42 deleted the fix/snapshot-test branch January 23, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration & testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants