Add coding worker profile setup#7
Conversation
📝 WalkthroughWalkthroughThis PR contains three independent updates: refactored health-probe reporting that defers harness-unavailable messages until core-stack results are known, an increased default timeout for chat commands from 10 to 30 minutes, and reordered user message construction that appends client context after the user prompt instead of prefixing it. ChangesConfiguration and Behavior Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/cli.rs (1)
139-140: ⚡ Quick winConsolidate the chat timeout default into a shared constant.
1_800_000is defined in both the clap arg (Line 139) andDefaultimpl (Line 160), which can drift later. Use one constant for both call sites.♻️ Proposed refactor
+const CHAT_STREAM_TIMEOUT_MS: u64 = 1_800_000; + #[derive(Debug, Args, Clone)] pub struct ChatArgs { @@ - #[arg(long, default_value_t = 1_800_000)] + #[arg(long, default_value_t = CHAT_STREAM_TIMEOUT_MS)] pub stream_timeout_ms: u64, @@ - stream_timeout_ms: 1_800_000, + stream_timeout_ms: CHAT_STREAM_TIMEOUT_MS,Also applies to: 160-160
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/cli.rs` around lines 139 - 140, Declare a single shared constant (e.g., STREAM_TIMEOUT_MS_DEFAULT or CHAT_TIMEOUT_MS_DEFAULT) and replace the duplicated literal 1_800_000 in both the clap arg attribute for stream_timeout_ms and the Default implementation for the struct so both sites reference that constant; update the #[arg(long, default_value_t = ...)] on stream_timeout_ms and the Default::default() field initialization to use the new constant (referencing stream_timeout_ms and the Default impl to find the two replacement locations).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/cli.rs`:
- Around line 139-140: Declare a single shared constant (e.g.,
STREAM_TIMEOUT_MS_DEFAULT or CHAT_TIMEOUT_MS_DEFAULT) and replace the duplicated
literal 1_800_000 in both the clap arg attribute for stream_timeout_ms and the
Default implementation for the struct so both sites reference that constant;
update the #[arg(long, default_value_t = ...)] on stream_timeout_ms and the
Default::default() field initialization to use the new constant (referencing
stream_timeout_ms and the Default impl to find the two replacement locations).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d3b4d1f2-e3a7-4b48-a5e8-b789d73ea870
📒 Files selected for processing (3)
src/app.rssrc/cli.rssrc/payload.rs
Summary
iii-code setup --coding-fullandiii-code doctor --coding-fullfor coding-adjacent workers (mcp,iii-lsp,iii-database).harness::statusto the core function stack.Validation
cargo fmt -- --checkcargo testcargo clippy --all-targets -- -D warningscargo install --path .iii-code doctor --coding-full(with live iii engine; core stack fallback ok, anthropic auth ok)Summary by CodeRabbit
Release Notes