Skip to content

fix(ci): use full function_id as registry name to avoid collisions#72

Merged
guibeira merged 1 commit intomainfrom
fix/registry-function-name-keep-namespace
May 4, 2026
Merged

fix(ci): use full function_id as registry name to avoid collisions#72
guibeira merged 1 commit intomainfrom
fix/registry-function-name-keep-namespace

Conversation

@guibeira
Copy link
Copy Markdown
Collaborator

@guibeira guibeira commented May 4, 2026

Summary

The skills v0.1.2 publish (failing job) was rejected by the registry with:

HTTP 422
{"error":"functions[4].name: duplicate of functions[0]"}

skills registers functions in two namespaces (skills::* and prompts::*) and derive_registry_function_name was stripping the namespace via rsplit("::", 1)[1], collapsing distinct function ids onto the same names:

function_id derived name (before)
skills::list list
prompts::list list
skills::register register
prompts::register register
skills::unregister unregister
prompts::unregister unregister

Default to the full function_id, so the registry sees skills::list and prompts::list as distinct. The metadata.registry_name / metadata.name overrides stay first in priority — workers that want a friendly short name can still opt in.

Test plan

  • Re-dispatch create-tag.yml with worker=skills, bump=patch, tag=next after this lands.
  • Build payload step shows function entries with names like skills::list, prompts::register, etc. (no duplicates).
  • POST /publish returns HTTP 200.

The skills worker registers functions in two namespaces (skills::* and prompts::*) and the registry rejected the publish with HTTP 422 "functions[4].name: duplicate of functions[0]". Cause: derive_registry_function_name stripped the namespace via rsplit("::", 1)[1], so skills::list, prompts::list, skills::register, prompts::register, etc. all collapsed to the same names.

Default to the full function_id so namespaced ids stay unique. Workers that want a custom short name can still set metadata.registry_name or metadata.name on the function — the priority chain is unchanged.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@guibeira has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 56 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 39263198-d737-4d16-959d-782604487d8a

📥 Commits

Reviewing files that changed from the base of the PR and between e98a88c and 49c3fe5.

📒 Files selected for processing (1)
  • .github/scripts/build_publish_payload.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/registry-function-name-keep-namespace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 31 minutes and 56 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@guibeira guibeira marked this pull request as ready for review May 4, 2026 19:43
@guibeira guibeira merged commit 2b78693 into main May 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant