Paper edits#56
Merged
Merged
Conversation
Open netcdf in context manager (with statement)
Added Hydro unit based on monthly expected generation to assetra.units, added test cases for hydro unit to unittests and created an example folder for the hydro unit based on the basic example
Hydrounit integration
typo in basic example and add openpyxl install note in ciso example
pulling from origin after update from Isaac on 8/20
edited paper
minor wording changes and author affiliation fixes
edits based on Michael's markups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding JOSS paper and bibliography edited to answer open issues